Fix issues associated with running locally #840
Conversation
josh-padnick
requested review from
eak12913,
ebeneliason,
oredavids and
pete0emerson
as code owners
✅ Deploy Preview for pensive-meitner-faaeee ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I wanted to run Docusaurus locally but kept getting Error: error:0308010C:digital envelope routines::unsupported
at String.replace (<anonymous>). This is apparently an issue due to using vulnerable dependencies that rely on outdated TLS standards.
So I ran `yarn-audit-fix`, this error went away, and our dependencies are patched to later versions.
I haven't done any additional testing beyond that, so I'm not sure if there are undesirable side effects from this change.
josh-padnick
force-pushed
the
fix-local-install
branch
from
1e9b29f to
207b581
Compare
|
FYI, the |
.gitignore
Outdated
|
|
||
| # VS Code files | ||
| .vscode | ||
| docs/guides/stay-up-to-date/index.md |
There was a problem hiding this comment.
We actually don't want to do this as that will make it much harder to change anything on this page if we ever want to do that.
Instead we need to either architect the docs-sourcer to allow this kind of functionality (ie - mixing auto-generated and manually written content on a page) or we need to update our IA such that this content gets separated.
There was a problem hiding this comment.
Ah, good point. Strangely, this .gitignore didn't work anyway. I think having a fully auto-generated page is the way to go.
Separately, it looks like https://docs.gruntwork.io/guides/stay-up-to-date/#gruntwork-releases is now hidden from the IA. Perhaps we should add a new page under Library called "Release Notes" that includes the releases section in https://docs.gruntwork.io/guides/stay-up-to-date/#gruntwork-releases?
package.json
Outdated
| "typescript": "^4.3.5", | ||
| "yargs": "^17.4.0" | ||
| "yargs": "^17.4.0", | ||
| "yarn-audit-fix": "^9.3.10" |
There was a problem hiding this comment.
Once you've run yarn-audit-fix, it has changed your lock file. Is there any point of keeping this dependency around?
There was a problem hiding this comment.
Fair enough! Removed in 1e9c420
|
@eak12913 This is now just a lock file change. Could you either approve and merge this, or close it out so we can remove this as a work-in-progress PR? |
I wanted to run Docusaurus locally so I could more easily propose updates to the content, but I kept getting dozens of instances of the following error:
Based on this Stack Overflow response, I ran
yarn-audit-fix, the errors went away, and our dependencies are patched to later versions.I haven't done any additional testing beyond that, so I'm not sure if there are undesirable side effects from this change.