Skip to content

Conversation

@ellisonc
Copy link

No description provided.

@gitguardian
Copy link

gitguardian bot commented Jun 22, 2023

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
4052097 Generic High Entropy Secret 709ce82 scripts/push-to-s3-prod.sh View secret
4052099 Generic High Entropy Secret 709ce82 scripts/push-to-s3-stage.sh View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@netlify
Copy link

netlify bot commented Jun 22, 2023

Deploy Preview for pensive-meitner-faaeee ready!

Name Link
🔨 Latest commit 179bbe8
🔍 Latest deploy log https://app.netlify.com/sites/pensive-meitner-faaeee/deploys/64944515bbbe640008a8fec7
😎 Deploy Preview https://deploy-preview-909--pensive-meitner-faaeee.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@pete0emerson pete0emerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ellisonc ellisonc merged commit 953668f into master Jun 22, 2023
@ellisonc ellisonc deleted the feature/CORE-914-ga branch June 22, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants