Skip to content

Fix rss feed entry encoding #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2020
Merged

Fix rss feed entry encoding #327

merged 1 commit into from
Jun 22, 2020

Conversation

@oredavids
Copy link
Contributor

No description provided.

@oredavids
Copy link
Contributor Author

@eak12913 I need approval.

eak12913
eak12913 reviewed Jun 18, 2020
View reviewed changes
Copy link
Contributor

@eak12913 eak12913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Fix" is a strong word here :-D Are you suggesting that we can't use any apostrophes, otherwise it is broken in the RSS feed?

Are there any options for controlling encoding in the plugin/config?

@oredavids
Copy link
Contributor Author

@eak12913 apostrophe is a special character in XML. It can be replaced with ' but I figured it was arguably better, grammatically, to replace the contraction we've with we have.

eak12913
eak12913 approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@eak12913 eak12913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roger - makes sense! LGTM in that case.

@oredavids oredavids merged commit 77ccf79 into master Jun 22, 2020
@oredavids oredavids deleted the chore/fix-rss-feed branch June 22, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josh-padnick josh-padnick Awaiting requested review from josh-padnick

@tsmit291 tsmit291 Awaiting requested review from tsmit291

1 more reviewer

@eak12913 eak12913 eak12913 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oredavids @eak12913