-
-
Notifications
You must be signed in to change notification settings - Fork 42
Task/update partner logos [WWW-90] #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Deploy preview for keen-clarke-470db9 ready! Built with commit 2375e3c |
|
Thanks, Ore! There are a few open items I see:
In this case, you might consider using the vertical HashiCorp logo:
We can remove CIS since it doesn't really fit with the others. And we focus more on Terraform than on HashiCorp in general. I realize there's some graphic design work here. If this is time-consuming, we could consider assigning this one to Altalogy, or you could invest in learning some graphic design. Your call. |
Agreed with all of this, but I think CIS could be quite valuable to have here. E.g., When you go look at websites for a product, don't well-known security standards (e.g., PCI, HIPAA, etc) make you trust the solution more? |
|
I would like to take the time to pick up the design skills to get the logos as desired but the initial task was estimated as a trivial @josh-padnick would Altalogy drop whatever they are working on right now to do this right away or add it to a backlog? Because I assume this is a priority. @eak12913 thoughts? Going to do a quick spike to see how much time this would take me to implement. |
|
Update: |
|
Thanks, Ore. FWIW, I use Pixelmator to apply a fill to the whole image to achieve this effect and it works pretty well. Based on Jim's comment, let's add in CIS, though we'll have to see how it works to fit in so many logos at once. Re: priority, the fact that this PR is public is evidence enough that we're taking this seriously IMO. If you have a lot on your plate and we need to delay by a few days by pushing to Altalogy that's ok with me. |
|
This is ready for another review. |
|
Just a note from Platform sync- can we align the edge of the first logo (aws) with the 'get demo' button? |
|
This is looking good, Ore! Some nitpicky final changes:
Otherwise, ready to launch! |
|
@josh-padnick done. |
|
Nice, but I'm actually finding a couple other issues. Sorry to drag it out:
|
1e09a5e to
f7740a4
Compare
|
@josh-padnick I've implemented your suggestions for 1, 2 & 4.
Doing this would result in losing the alignment on the right with the other images further down on the page. Is that Ok? Also, in the mobile view; would you want to place the "Get Demo" button above centrally to align with the logos? |
That's a good question. My take on this is that we have an invisible line on the left side where things are aligned, but not on the right. For spacing on IPad, feel free to use your judgment on what looks best. Either way should be fine.
Good pickup! I actually realize now that everything is left-aligned except those logos, which we've now centered. Nothing obvious occurs to me here, but one thought is that you could left-align the top 4 logos on one row and on the next row either left-align or center the CIS logo. Not sure here. |
|
@josh-padnick I've adjusted the display on the iPad. I think we should leave the 2 columns arrangement on the smaller devices as it is for now. Placing all 4 logos on one row doesn't scale well as the device screen gets smaller. I didn't get a better feel by making the logos smaller too. If you are ok with that; I need the approval to get this merged. |
|
Fair enough! This looks great, Ore. Approving! |
|
@brikis98 do we need to inform Hashicorp we've effected the change? |
|
No, I don't think so. |


Uh oh!
There was an error while loading. Please reload this page.