Skip to content

set up CircleCI#17

Merged
JJediny merged 14 commits intomasterfrom
ci
Jul 26, 2017
Merged

set up CircleCI#17
JJediny merged 14 commits intomasterfrom
ci

Conversation

@afeld
Copy link
Contributor

@afeld afeld commented Jul 25, 2017 •
edited
Loading

  • Set some missing variables that I failed to copy over originally
  • Add a check for the validity of the nginx config
  • Remove TravisCI configuration (added by default by ansible-galaxy init)
  • Run the role via the test playbook in CircleCI

Follow-up TODOs

@afeld
Copy link
Contributor Author

afeld commented Jul 26, 2017

The good news is, this failure is legitimate 🎉

@afeld afeld requested a review from JJediny July 26, 2017 04:25
@afeld afeld changed the title [WORK IN PROGRESS] set up CircleCI set up CircleCI Jul 26, 2017
@afeld afeld mentioned this pull request Jul 26, 2017
Merged
afeld
afeld commented Jul 26, 2017
View reviewed changes
tests/hosts Outdated
Copy link
Contributor Author

@afeld afeld Jul 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This setting was a huge discovery.

Copy link
Member

@JJediny JJediny Jul 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh this is new to me to...

@afeld afeld mentioned this pull request Jul 26, 2017
Merged
afeld added 4 commits July 26, 2017 02:29
@afeld
dramatically simplify CI setup
604ec31 
Execute Ansible using the Docker remote connection, rather than
executing Ansible from within the container. This means we can use a
target container without Ansible installed, more closely mirroring
what a bare CentOS target machine would look like when using the role
for real.
@afeld
remove unused TravisCI files
4badbd4
@afeld
simplify role naming within CircleCI
661eeb0
@afeld
add documentation around local development
c172cef
JJediny
JJediny approved these changes Jul 26, 2017
View reviewed changes
Copy link
Member

@JJediny JJediny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JJediny JJediny merged commit ff0493b into master Jul 26, 2017
@afeld afeld deleted the ci branch July 26, 2017 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JJediny JJediny JJediny approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@afeld @JJediny