Skip to content

Conversation

@linuxrrze
Copy link

…f" (default)

Copy link
Contributor

@iboukris iboukris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

Copy link
Member

@frozencemetery frozencemetery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this is in line with what we wanted for #115

@frozencemetery
Copy link
Member

@linuxrrze Thanks for the PR! However, Simo will probably want the following changes

  • Signed-off-by: header in commit message (git commit --amend -s; git push --force will take care of this)
  • Line length limit on commit message (I'd suggest moving the issue reference into a header during the git commit --amend -s above)

Additionally, you may wish to configure GitHub to know about the email address you committed from so that it will track on your profile.

broken ccache name when "GssapiDelegCcacheUnique Off" (default)

Signed-off-by: Marcel Ritter <ritter.marcel@googlemail.com>
@simo5 simo5 closed this in 4e80ca6 Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants