-
Notifications
You must be signed in to change notification settings - Fork 41
Add option to store the session encryption key. #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@frozencemetery @Frenche can you review ? |
|
I would prefer for the "file:" branch of the |
README
Outdated
|
|
||
| #### Example | ||
| - 'key' | ||
| A key is read the key straight from the configuration directive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this sentence could be revised
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do.
README
Outdated
|
|
||
| #### Examples | ||
| GssapiSessionKey key:VGhpcyBpcyBhIDMyIGJ5dGUgbG9uZyBzZWNyZXQhISE= | ||
| GssapiSessionKey file:/etc/httpd/secrets/session.key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe /var/ is a better location for an auto-generated binary file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could go either way, I think. It's going to be up to administrators (and distro packagers, I suppose) what the path is here since there isn't a default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, was just a thought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can change the example to point to /var/lib/httpd/secrets; it is a good subliminal suggestion :-)
With the new 'file:' sytnax a session key can be automatically generated the first time mod_auth_gssapi runs and stored on the filesystem. Signed-off-by: Simo Sorce <simo@redhat.com>
|
Ok all concenrs should be addressed, I also changed a test to actually use this feature. |
|
master is passing on fedora 24, failing the first SPNEGO test on debian testing, and trips an assert inside apache on rawhide: I am happy with the code as written here. |
With the new 'file:' sytnax a session key can be automatically generated
the first time mod_auth_gssapi runs and stored on the filesystem.