Skip to content

Conversation

@simo5
Copy link
Contributor

@simo5 simo5 commented Dec 19, 2016

With the new 'file:' sytnax a session key can be automatically generated
the first time mod_auth_gssapi runs and stored on the filesystem.

@simo5
Copy link
Contributor Author

simo5 commented Dec 19, 2016

@frozencemetery @Frenche can you review ?
(Tested and works)

@frozencemetery
Copy link
Member

I would prefer for the "file:" branch of the if statement (L1268-L1322) to be broken into smaller pieces (or a helper function, or something), but otherwise this looks good to me.

README Outdated

#### Example
- 'key'
A key is read the key straight from the configuration directive.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this sentence could be revised

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

README Outdated

#### Examples
GssapiSessionKey key:VGhpcyBpcyBhIDMyIGJ5dGUgbG9uZyBzZWNyZXQhISE=
GssapiSessionKey file:/etc/httpd/secrets/session.key
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe /var/ is a better location for an auto-generated binary file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could go either way, I think. It's going to be up to administrators (and distro packagers, I suppose) what the path is here since there isn't a default.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, was just a thought.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can change the example to point to /var/lib/httpd/secrets; it is a good subliminal suggestion :-)

With the new 'file:' sytnax a session key can be automatically generated
the first time mod_auth_gssapi runs and stored on the filesystem.

Signed-off-by: Simo Sorce <simo@redhat.com>
@simo5
Copy link
Contributor Author

simo5 commented Dec 20, 2016

Ok all concenrs should be addressed, I also changed a test to actually use this feature.
however running make test I saw one test failing (it fails also reverting this commit so it is a pre-existing issue).
@frozencemetery can you look into whether make test fails for you ?

@frozencemetery
Copy link
Member

master is passing on fedora 24, failing the first SPNEGO test on debian testing, and trips an assert inside apache on rawhide:

[Tue Dec 20 18:02:34.459405 2016] [core:emerg] [pid 1412] (22)Invalid argument: AH00024: Couldn't set permissions on the mpm-accept mutex; check User and Group directives
(22)Invalid argument: could not create accept mutex
AH00015: Unable to open logs

I am happy with the code as written here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants