Allow returning errors as Environment Variables #130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function declaration and comments should not exceed 80 chars. Do not use C++ style comments Signed-off-by: Simo Sorce <simo@redhat.com>
Introduce a new option to export errors in environment variables. This allows applications to display better errors or take actions based on the returned error type. Signed-off-by: Simo Sorce <simo@redhat.com> Resolves gssapi#128 Resolves gssapi#129
Contributor
|
Thanks Simo. Everything seems ok. I've tested it and I'm getting what I want, except for one important case. When no auth data has been sent, this is silently discarded (but 401 page is shown). I would need some NO_AUTH_DATA error here to know when the Client's user agent is not behaving as the user thinks (e.g misconfigured). Most notable error is not adding the network.negotiate-auth.trusted-uris key in Firefox. In that case, FF does not send auth data, and the module is not exporting any MAG_ERROR. |
Signed-off-by: Simo Sorce <simo@redhat.com>
simo5
force-pushed
the
gss_env_errors
branch
from
4e07f2c to
d8c4ed0
Compare
Contributor
Author
|
Fixed that, please verify |
Contributor
|
Yes, it is fixed now. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first stab at implementing the features requested in #128 and #129.
@alejandro-perez @frozencemetery @Frenche please comment.