Add option to select acceptor name #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iboukris
reviewed
Feb 24, 2017
src/mod_auth_gssapi.c
Outdated
| &cfg->acceptor_name); | ||
| if (GSS_ERROR(maj)) { | ||
| ap_log_error(APLOG_MARK, APLOG_WARNING, 0, parms->server, | ||
| "gss_import_name([%s]) failed", w); |
Contributor
There was a problem hiding this comment.
Why not return "error: malformed name" here? I think it is more useful to detect the error at init time.
Contributor
Author
There was a problem hiding this comment.
Are you suggesting to log at APLOG_ERROR level, or also to return a non-NULL error ?
Contributor
There was a problem hiding this comment.
Return non-null, so the directive won't get silently ignored.
Contributor
Author
|
Ok now a bad name (like an empry name) returns an error. |
simo5
added a commit
to simo5/mod_auth_gssapi
that referenced
this pull request
Feb 27, 2017
This option is useful to select and allow only a specific credential when keys for multiple principals are available in a keytab. Signed-off-by: Simo Sorce <simo@redhat.com> Reviewed-by: Robbie Harwood <rharwood@redhat.com> Reviewed-by: Isaac Boukris <iboukris@gmail.com> Closes gssapi#131
This way this error reporting function can be used also when a request_rec is not available, like i the configuration phase. Signed-off-by: Simo Sorce <simo@redhat.com> Reviewed-by: Robbie Harwood <rharwood@redhat.com> Reviewed-by: Isaac Boukris <iboukris@gmail.com>
This option is useful to select and allow only a specific credential when keys for multiple principals are available in a keytab. Signed-off-by: Simo Sorce <simo@redhat.com> Reviewed-by: Robbie Harwood <rharwood@redhat.com> Reviewed-by: Isaac Boukris <iboukris@gmail.com> Closes gssapi#131
simo5
added a commit
that referenced
this pull request
Mar 1, 2017
Had this in my tree but forgot to add to the commit. Related to #131 Signed-off-by: Simo Sorce <simo@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option is useful to select and allow only a specific credential
when keys for multiple principals are available in a keytab.