v1.1.0-beta - Incorrect naming of 1 file in `directory-info`

[khusika]

Description
If there is 1 file with any extension inside/outside a folder, directory-info will refer to it as 1 buttons.file, but this does not apply if there is more than 1 file.

Expected behaviour
directory-info should refer to 1 File instead of 1 buttons.file

[Kurami32]

Ah, this should be because the translation key that I used was moved. Now I see that's under general and no in buttons.

[gtsteffaniak]

as a side note, this is usually a requirement to build. But it doesn't get checked if the i18n keys are inside a function like this

So I always make sure to specify these keys directly with $t('key.key') and never use i18n inside a function.

I am not sure when the key changed from button to general but I did see another case of that during the merge.

[Kurami32]

Ah, I didn't knew that the tests were skipped if I did it that way, I'll keep that in mind 👍

(btw, thanks for fix it)

[gtsteffaniak]

yeah it wasn't clear at first either and I found out thats why some were not getting validated.

I think almost everything else is checked during build, so its just about making sure new changes always have $t('string.key') everywhere. I didn't think about that when reviewing either

[khusika]

Fixed in #1655