Skip to content

Commit 4f0a76e

Browse files
committed
Run js linter/fixer on test
1 parent 9b6afbf commit 4f0a76e

File tree

4 files changed

+22
-0
lines changed

4 files changed

+22
-0
lines changed

install_travis_dependencies.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,5 @@ if [[ $languages == *"node"* ]]; then
3131
export NVM_DIR="$HOME/.nvm"
3232
[ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh"
3333
nvm install --lts
34+
npm install
3435
fi

tools/snippet-testing/language_handler/base_handler.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ class BaseHandler
1313
' to use v5 of ruby\'s Twilio ' \
1414
'library for example'.freeze
1515

16+
ROOT_FOLDER = "#{__dir__}/../../../"
17+
1618
attr_reader :dependencies_directory, :dependencies
1719

1820
def initialize(dependencies_directory = Dir.pwd, dependencies = [])
@@ -34,6 +36,9 @@ def test_snippet(snippet_model)
3436
execute(path)
3537
end
3638

39+
def run_before_test
40+
end
41+
3742
private
3843

3944
def execute(file)

tools/snippet-testing/language_handler/node.rb

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,15 @@ module LanguageHandler
44
class Node < BaseHandler
55
LANG_CNAME = 'js'.freeze
66

7+
def self.run_before_test
8+
Dir.chdir(ROOT_FOLDER) do
9+
output = `npm run test:js -- --fix && npm run format:js 1>/dev/null`
10+
if $? != 0
11+
abort(output)
12+
end
13+
end
14+
end
15+
716
private
817

918
def execute_command(file)

tools/snippet-testing/snippet_tester.rb

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,12 @@ def setup
4444
end
4545
end
4646

47+
def run_before_test
48+
if !ENV['SNIPPET_LANGUAGE'] || (ENV['SNIPPET_LANGUAGE'].include? 'node')
49+
LanguageHandler::Node.run_before_test
50+
end
51+
end
52+
4753
def run
4854
@snippet_models.each do |snippet|
4955
puts "Testing #{snippet.output_folder}"
@@ -230,6 +236,7 @@ def parse_options(args)
230236
tester = SnippetTester.new(options.source_folder, options.test_default)
231237

232238
tester.install_dependencies if options.install
239+
tester.run_before_test
233240
tester.init
234241
tester.setup
235242
tester.run

0 commit comments

Comments
 (0)