Refactor 2nd round

Author: well1791

add-ons/lookups/payfone-tcpa-compliance/payfone-tcpa-compliance.5.x.rb

@@ -8,11 +8,11 @@
 # Initialize Twilio Client
 @client = Twilio::REST::Client.new(account_sid, auth_token)
 
+key = 'payfone_tcpa_compliance.RightPartyContactedDate'
+
 number = @client.lookups.v1
-                .phone_numbers('+16502530000') \
+                .phone_numbers('+16502530000')
                 .fetch(add_ons: 'payfone_tcpa_compliance',
-                       add_ons_data: {
-                         'payfone_tcpa_compliance.RightPartyContactedDate' => '20160101'
-                       })
+                       add_ons_data: { key => '20160101' })
 
 print(number.add_ons)

client/capability-token-expires/capability-token-expires.4.x.rb

@@ -1 +1,3 @@
-token = capability.generate expires = 600
+token = capability.generate expires: 600
+
+puts token

client/capability-token-expires/capability-token-expires.5.x.rb

@@ -1 +1,3 @@
-token = capability.generate expires = 600
+token = capability.generate expires: 600
+
+puts token

client/response-twiml-client/response-twiml-client.4.x.rb

@@ -7,7 +7,7 @@
       r.Dial callerId: '+15017250604' do |d|
         # wrap the phone number or client name in the appropriate TwiML verb
         # by checking if the number given has only digits and format symbols
-        if params['To'] =~ /^[\d\+\-\(\) ]+$/
+        if params['To'].match?(/^[\d\+\-\(\) ]+$/)
           d.Number params['To']
         else
           d.Client params['To']

client/response-twiml-client/response-twiml-client.5.x.rb

@@ -7,7 +7,7 @@
       r.Dial callerId: '+15017250604' do |d|
         # wrap the phone number or client name in the appropriate TwiML verb
         # by checking if the number given has only digits and format symbols
-        if params['To'] =~ /^[\d\+\-\(\) ]+$/
+        if params['To'].match?(/^[\d\+\-\(\) ]+$/)
           d.Number params['To']
         else
           d.Client params['To']

fax/sip-send/example-3/example-3.5.x.rb

@@ -7,14 +7,12 @@
 
 uri = URI('https://fax.twilio.com/v1/Faxes')
 
-Net::HTTP.start(uri.host, uri.port,
-                use_ssl: uri.scheme == 'https') do |http|
-
+Net::HTTP.start(uri.host, uri.port, use_ssl: uri.scheme == 'https') do |http|
   request = Net::HTTP::Post.new uri.request_uri
   request.basic_auth account_sid, auth_token
-  request.body = URI.encode_www_form(To: 'sip:kate@example.com?hatchkey=4815162342;transport=TCP',
-                                     From: 'Jack',
-                                     MediaUrl: 'https://www.twilio.com/docs/documents/25/justthefaxmaam.pdf')
+  to = 'sip:kate@example.com?hatchkey=4815162342;transport=TCP'
+  media_url = 'https://www.twilio.com/docs/documents/25/justthefaxmaam.pdf'
+  request.body = URI.encode_www_form(to: to, from: 'Jack', media_url: media_url)
 
   response = http.request request
 

guides/voice/conference-calls-guide/moderated-conference/moderated-conference.4.x.rb

@@ -14,7 +14,9 @@
       if params['From'] == MODERATOR
         # If the caller is our MODERATOR, then start the conference when they
         # join and end the conference when they leave
-        d.Conference 'My conference', startConferenceOnEnter: true, endConferenceOnExit: true
+        d.Conference('My conference',
+                     startConferenceOnEnter: true,
+                     endConferenceOnExit: true)
       else
         # Otherwise have the caller join as a regular participant
         d.Conference 'My conference', startConferenceOnEnter: false

ip-messaging/rest/channels/create-channels/create-channels.4.x.rb

@@ -3,9 +3,11 @@
 # Initialize the client
 account_sid = 'ACXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX'
 auth_token = 'your_auth_token'
-ip_messaging_client = Twilio::REST::IpMessagingClient.new(account_sid, auth_token)
+ip_messaging_client = Twilio::REST::IpMessagingClient.new account_sid,
+                                                          auth_token
 
 # Create the channel
-service = ip_messaging_client.services.get('ISXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX')
-channel = service.channels.create
+channel = ip_messaging_client
+          .services.get('ISXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX')
+          .channels.create
 puts channel

ip-messaging/rest/channels/delete-channels/delete-channels.4.x.rb

@@ -3,10 +3,12 @@
 # initialize the client
 account_sid = 'ACXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX'
 auth_token = 'your_auth_token'
-ip_messaging_client = Twilio::REST::IpMessagingClient.new(account_sid, auth_token)
+ip_messaging_client = Twilio::REST::IpMessagingClient.new account_sid,
+                                                          auth_token
 
 # Delete the channel
-service = ip_messaging_client.services.get('ISXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX')
-channel = service.channels.create
-response = channel.delete
+response = ip_messaging_client
+           .services.get('ISXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX')
+           .channels.create
+           .delete
 puts response

ip-messaging/rest/channels/list-channels/list-channels.4.x.rb

@@ -3,9 +3,11 @@
 # Initialize the client
 account_sid = 'ACXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX'
 auth_token = 'your_auth_token'
-ip_messaging_client = Twilio::REST::IpMessagingClient.new(account_sid, auth_token)
+ip_messaging_client = Twilio::REST::IpMessagingClient.new account_sid,
+                                                          auth_token
 
 # List the channels
-service = ip_messaging_client.services.get('ISXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX')
-channels = service.channels.list
+channels = ip_messaging_client
+           .services.get('ISXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX')
+           .channels.list
 puts channels