refactor: remove self-generated openapi-spec #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruromero
force-pushed
the
refactor/schema-gen
branch
2 times, most recently
from
d901533 to
cb64549
Compare
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
ruromero
force-pushed
the
refactor/schema-gen
branch
from
cb64549 to
a580bc4
Compare
Strum355
reviewed
May 13, 2025
Member
|
The following places will also need updating so the types resolve in JSDoc |
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
Strum355
reviewed
May 14, 2025
Strum355
previously approved these changes
May 14, 2025
Member
Strum355
left a comment
Strum355
left a comment
There was a problem hiding this comment.
Besides the comment about @overload, the jsdoc is good to go 👍
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
ruromero
force-pushed
the
refactor/schema-gen
branch
from
2a264d7 to
6f58ae7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove dependency with self generated openapi spec and rely on the exhort-api-spec generated library
Fix: #199
Checklist