-
Notifications
You must be signed in to change notification settings - Fork 20
feat: add tc recommendations to EXHORT #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tc recommendations to EXHORT #226
Conversation
Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
also modify response payload of trusted content /recommend and adjust tests accordingly Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
3168332 to
286a3d7
Compare
Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
a025aad to
5bc0772
Compare
Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
5bc0772 to
7bc1f61
Compare
ruromero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @zvigrinberg I have added some suggestions although the functionality doesn't change, it aligns with the existing code
src/main/java/com/redhat/exhort/integration/backend/ExhortIntegration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/redhat/exhort/integration/trustedcontent/TrustedContentIntegration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/redhat/exhort/integration/trustedcontent/TrustedContentIntegration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/redhat/exhort/integration/trustedcontent/TrustedContentIntegration.java
Show resolved
Hide resolved
src/main/java/com/redhat/exhort/integration/trustedcontent/TrustedContentIntegration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/redhat/exhort/integration/trustedcontent/TrustedContentIntegration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/redhat/exhort/integration/trustedcontent/TrustedContentIntegration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/redhat/exhort/integration/trustedcontent/TcResponseHandler.java
Show resolved
Hide resolved
|
I have one concern about the overall approach. Wouldn't it be simpler to call the trustedContent before the providers and then keep the response in the exchange so that in the response handling we can have a common code to aggregate individually not only for recommendations but also for remediations as there will be where we have the CVEs information. |
Let's discuss it tomorrow. |
Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
bcfb944 to
baa5abc
Compare
In order to enforce unified error handling process Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
|
@ruromero As discussed, all the changes that you've requested are here, Please review and approve. |
Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
src/main/java/com/redhat/exhort/integration/trustedcontent/TrustedContentIntegration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/redhat/exhort/integration/trustedcontent/TrustedContentIntegration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/redhat/exhort/integration/trustedcontent/TcResponseHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/redhat/exhort/integration/trustedcontent/TcResponseHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
Integrate Trusted content recommendations into EXHORT' response payload.
/recommendendpointRemark: TC service' endpoint -
/recommendis under ongoing development, so integration changes caused by it might follow.