refactor(rector): apply rector

Author: guanguans

app/Commands/BuildCommand.php

@@ -82,7 +82,7 @@ public function __destruct()
      * @noinspection PhpMissingReturnTypeInspection
      * @noinspection PhpMissingParentCallCommonInspection
      */
-    public function isEnabled()
+    public function isEnabled(): bool
     {
         return ! $this->laravel->isProduction();
     }

app/Exceptions/Handler.php

@@ -38,7 +38,7 @@ public function renderForConsole($output, \Throwable $e): void
      * @noinspection ReturnTypeCanBeDeclaredInspection
      * @noinspection PhpMissingReturnTypeInspection
      */
-    protected function shouldntReport(\Throwable $e)
+    protected function shouldntReport(\Throwable $e): bool
     {
         if ($this->container->isProduction()) {
             return true;

app/GeneratorManager.php

@@ -28,7 +28,7 @@ final class GeneratorManager extends Manager
     use Conditionable;
     use Tappable;
 
-    public function getDefaultDriver()
+    public function getDefaultDriver(): string
     {
         return $this->config->get('ai-commit.generator');
     }

app/Generators/ErnieBotGenerator.php

@@ -25,14 +25,14 @@
 class ErnieBotGenerator implements GeneratorContract
 {
     /**
-     * @var array
+     * @var \App\Support\Ernie
      */
-    private $config = [];
+    protected $ernie;
 
     /**
-     * @var \App\Support\Ernie
+     * @var array
      */
-    protected $ernie;
+    private $config = [];
 
     /**
      * @var \Illuminate\Console\OutputStyle
@@ -71,19 +71,19 @@ public function generate(string $prompt): string
     }
 
     /**
-     * @param array|ArrayAccess $response
+     * @throws RequestException
+     * @throws BindingResolutionException
      */
-    private function getCompletionMessages($response): string
+    protected function completion(array $parameters, ?callable $writer = null): Response
     {
-        return Arr::get($response, 'result', '');
+        return $this->ernie->ernieBot($parameters, $writer);
     }
 
     /**
-     * @throws RequestException
-     * @throws BindingResolutionException
+     * @param array|ArrayAccess $response
      */
-    private function completion(array $parameters, ?callable $writer = null): Response
+    private function getCompletionMessages($response): string
     {
-        return $this->ernie->ernieBot($parameters, $writer);
+        return Arr::get($response, 'result', '');
     }
 }

app/Support/helpers.php

@@ -65,7 +65,7 @@ public function __call($method, $parameters)
                     return Str::$method(...$parameters);
                 }
 
-                public function __toString()
+                public function __toString(): string
                 {
                     return '';
                 }

rector.php

@@ -33,7 +33,6 @@
 use Rector\EarlyReturn\Rector\Return_\ReturnBinaryOrToEarlyReturnRector;
 use Rector\Naming\Rector\Assign\RenameVariableToMatchMethodCallReturnTypeRector;
 use Rector\Naming\Rector\ClassMethod\RenameParamToMatchTypeRector;
-use Rector\Php56\Rector\FunctionLike\AddDefaultValueForUndefinedVariableRector;
 use Rector\Php73\Rector\FuncCall\JsonThrowOnErrorRector;
 use Rector\PHPUnit\Set\PHPUnitLevelSetList;
 use Rector\PHPUnit\Set\PHPUnitSetList;
@@ -80,7 +79,6 @@
     $rectorConfig->skip([
         // rules
         // AddArrayDefaultToArrayPropertyRector::class,
-        // AddDefaultValueForUndefinedVariableRector::class,
         // CallableThisArrayToAnonymousFunctionRector::class,
         // ChangeAndIfToEarlyReturnRector::class,
         // RemoveEmptyClassMethodRector::class,
@@ -111,6 +109,7 @@
         ],
         FinalizeClassesWithoutChildrenRector::class => [
             __DIR__.'/app/Generators/OpenAIGenerator.php',
+            __DIR__.'/app/Generators/ErnieBotGenerator.php',
         ],
         JsonThrowOnErrorRector::class => [
             __DIR__.'/app/Generators/OpenAIGenerator.php',

tests/Pest.php

@@ -86,7 +86,7 @@ function setup_http_fake(): void
                 return array_flip(Response::$statusTexts)[$prompt] ?? 200;
             });
 
-            $text = transform($prompt, function ($prompt) {
+            $text = transform($prompt, function ($prompt): string {
                 switch ($prompt) {
                     case 'empty':
                         $text = '';