refactor(ConfigCommand): use dependency injection for ExecutableFinder

- Replace the instantiation of ExecutableFinder in the ConfigCommand class with dependency injection to increase code modularity and testability.
- Update the handle method signature to include the ExecutableFinder parameter.

Author: guanguans

app/Commands/ConfigCommand.php

@@ -68,7 +68,7 @@ public function __construct()
     /**
      * @throws \JsonException
      */
-    public function handle(): int
+    public function handle(ExecutableFinder $executableFinder): int
     {
         $file = value(function () {
             if ($file = $this->option('file')) {
@@ -123,13 +123,12 @@ public function handle(): int
 
                 break;
             case 'edit':
-                $editor = value(function () {
+                $editor = value(function () use ($executableFinder) {
                     if ($editor = $this->option('editor')) {
                         return $editor;
                     }
 
                     $editors = windows_os() ? self::WINDOWS_EDITORS : self::UNIX_EDITORS;
-                    $executableFinder = new ExecutableFinder();
                     foreach ($editors as $editor) {
                         if ($executableFinder->find($editor)) {
                             return $editor;

tests/Feature/ConfigCommandTest.php

@@ -14,8 +14,8 @@
 use App\ConfigManager;
 use App\Exceptions\RuntimeException;
 use App\Exceptions\UnsupportedConfigActionException;
-use Symfony\Component\Process\Exception\RuntimeException as SymfonyRuntimeException;
-use Symfony\Component\Process\Process;
+use Symfony\Component\Process\Exception\ProcessFailedException;
+use Symfony\Component\Process\ExecutableFinder;
 
 it('can set config', function (): void {
     $this->getFunctionMock(class_namespace(ConfigCommand::class), 'file_exists')
@@ -104,58 +104,47 @@
     ])->assertSuccessful();
 })->group(__DIR__, __FILE__);
 
-it('will throw RuntimeException for edit config on Windows', function (): void {
-    $this->artisan(ConfigCommand::class, [
-        'action' => 'edit',
-    ]);
-})
-    ->group(__DIR__, __FILE__)
-    ->skip(! windows_os())
-    ->throws(RuntimeException::class, 'The edit config command is not supported on Windows.');
-
-it('will throw RuntimeException for edit config', function (): void {
-    $this->getFunctionMock(class_namespace(ConfigCommand::class), 'exec')
-        ->expects($this->exactly(6))
-        ->willReturn('');
-
+it('will throw `Command not found` ProcessFailedException for edit config', function (): void {
     $this->artisan(ConfigCommand::class, [
         'action' => 'edit',
+        '--editor' => 'foo',
     ]);
 })
     ->group(__DIR__, __FILE__)
-    ->skip(windows_os())
-    ->throws(RuntimeException::class, 'No editor found or specified.');
+    ->throws(ProcessFailedException::class);
 
-it('will throw \SymfonyRuntimeException for edit config', function (): void {
-    $this->getFunctionMock(class_namespace(Process::class), 'proc_open')
-        ->expects($this->once())
-        ->willReturn(false);
+it('will throw another `Command not found` ProcessFailedException for edit config', function (): void {
+    app()->singleton(ExecutableFinder::class, static function () {
+        return new class() extends ExecutableFinder {
+            public function find(string $name, ?string $default = null, array $extraDirs = []): string
+            {
+                return 'foo';
+            }
+        };
+    });
 
     $this->artisan(ConfigCommand::class, [
         'action' => 'edit',
-        '--editor' => 'foo',
     ]);
 })
     ->group(__DIR__, __FILE__)
-    ->skip()
-    ->throws(SymfonyRuntimeException::class, 'TTY mode requires /dev/tty to be read/writable.');
+    ->throws(ProcessFailedException::class);
 
-it('will throw SymfonyRuntimeException for edit config', function (): void {
-    $this->getFunctionMock(class_namespace(ConfigCommand::class), 'exec')
-        ->expects($this->once())
-        ->willReturn('/usr/local/bin/vim');
-
-    $this->getFunctionMock(class_namespace(Process::class), 'proc_open')
-        ->expects($this->any())
-        ->willReturn(false);
+it('will throw RuntimeException for edit config', function (): void {
+    app()->singleton(ExecutableFinder::class, static function () {
+        return new class() extends ExecutableFinder {
+            public function find(string $name, ?string $default = null, array $extraDirs = []): void
+            {
+            }
+        };
+    });
 
     $this->artisan(ConfigCommand::class, [
         'action' => 'edit',
     ]);
 })
     ->group(__DIR__, __FILE__)
-    ->skip(windows_os())
-    ->throws(SymfonyRuntimeException::class, 'TTY mode requires /dev/tty to be read/writable.');
+    ->throws(RuntimeException::class, 'Unable to find a default editor or specify the editor.');
 
 it('will throw UnsupportedConfigActionException', function (): void {
     $this->artisan(ConfigCommand::class, [