perf(commands): Improve null handling and code clarity

- Update variable type hint for originalOutput to allow null.
- Adjust condition for checking null key in ConfigCommand for better readability.
- Document exception throwing in argToValue method.
- Remove commented-out code in valueToArg for cleaner implementation.

Author: ityaozm@gmail.com

app/Commands/BuildCommand.php

@@ -59,7 +59,7 @@ final class BuildCommand extends Command
     /**
      * Holds the command original output.
      *
-     * @var \Symfony\Component\Console\Output\OutputInterface
+     * @var null|\Symfony\Component\Console\Output\OutputInterface
      */
     private $originalOutput;
 

app/Commands/CommitCommand.php

@@ -349,6 +349,18 @@ private function getCommitCommand(Collection $message): array
         return array_merge(['git', 'commit', '--message', $this->hydrateMessage($message)], $options);
     }
 
+    private function hydrateMessage(Collection $message): string
+    {
+        return $message
+            ->map(static function (string $val): string {
+                return trim($val, " \t\n\r\x0B");
+            })
+            ->filter(static function ($val) {
+                return $val;
+            })
+            ->implode(str_repeat(PHP_EOL, 2));
+    }
+
     private function shouldntEdit(): bool
     {
         return ! Process::isTtySupported() || $this->option('no-edit') || $this->configManager->get('no_edit');
@@ -371,16 +383,4 @@ private function shouldVerify(): bool
     {
         return ! $this->shouldntVerify();
     }
-
-    private function hydrateMessage(Collection $message): string
-    {
-        return $message
-            ->map(static function (string $val): string {
-                return trim($val, " \t\n\r\x0B");
-            })
-            ->filter(static function ($val) {
-                return $val;
-            })
-            ->implode(str_repeat(PHP_EOL, 2));
-    }
 }

app/Commands/ConfigCommand.php

@@ -88,7 +88,7 @@ public function handle(ExecutableFinder $executableFinder): int
         $action = $this->argument('action');
         $key = $this->argument('key');
 
-        if (\in_array($action, ['set', 'unset'], true) && null === $key) {
+        if (null === $key && \in_array($action, ['set', 'unset'], true)) {
             $this->output->error('Please specify the parameter key.');
 
             return self::FAILURE;
@@ -206,8 +206,11 @@ protected function initialize(InputInterface $input, OutputInterface $output): v
     }
 
     /**
-     * @throws \JsonException
      * @noinspection PhpInconsistentReturnPointsInspection
+     *
+     * @throws \JsonException
+     *
+     * @return mixed
      */
     private function argToValue(string $arg)
     {
@@ -241,13 +244,13 @@ private function argToValue(string $arg)
      */
     private function valueToArg($value): string
     {
-        if (null === $value) {
-            return 'null';
-        }
-
-        if (\is_scalar($value)) {
-            return var_export($value, true);
-        }
+        // if (null === $value) {
+        //     return 'null';
+        // }
+        //
+        // if (\is_scalar($value)) {
+        //     return var_export($value, true);
+        // }
 
         return (string) json_encode($value, JSON_PRETTY_PRINT | JSON_UNESCAPED_UNICODE);
     }

app/Commands/ThanksCommand.php

@@ -18,15 +18,11 @@
 final class ThanksCommand extends Command
 {
     /**
-     * The signature of the command.
-     *
      * @var string
      */
     protected $signature = 'thanks';
 
     /**
-     * The description of the command.
-     *
      * @var string
      */
     protected $description = 'Thanks for using this tool.';

rector.php

@@ -11,7 +11,6 @@
  */
 
 use Rector\Caching\ValueObject\Storage\FileCacheStorage;
-use Rector\CodeQuality\Rector\Array_\CallableThisArrayToAnonymousFunctionRector;
 use Rector\CodeQuality\Rector\Class_\CompleteDynamicPropertiesRector;
 use Rector\CodeQuality\Rector\Class_\InlineConstructorDefaultToPropertyRector;
 use Rector\CodeQuality\Rector\ClassMethod\ExplicitReturnNullRector;
@@ -75,7 +74,6 @@
 
     $rectorConfig->skip([
         // rules
-        // CallableThisArrayToAnonymousFunctionRector::class,
         // RemoveEmptyClassMethodRector::class,
         // RemoveUnusedVariableAssignRector::class,
         // SimplifyBoolIdenticalTrueRector::class,