refactor(Generator): Refactor Generator class

- Remove unused closure param
- Add missing parameter type declaration
- Suppress undefined interface method
- Remove sanitizeJson method

Author: ityaozm@gmail.com

app/Generators/BitoCliGenerator.php

@@ -16,9 +16,6 @@
 
 final class BitoCliGenerator extends Generator
 {
-    /**
-     * @psalm-suppress UnusedClosureParam
-     */
     public function generate(string $prompt): string
     {
         return $this

app/Generators/Generator.php

@@ -73,6 +73,7 @@ public function mustRunProcess(
     /**
      * @param array|string|\Symfony\Component\Process\Process $cmd
      * @noinspection MissingParameterTypeDeclarationInspection
+     * @psalm-suppress UndefinedInterfaceMethod
      */
     public function runProcess(
         $cmd,
@@ -102,15 +103,4 @@ public function getHelper(string $name): HelperInterface
     {
         return $this->helperSet->get($name);
     }
-
-    public function sanitizeJson(string $json): string
-    {
-        return (string) str($json)
-            ->match('/\{.*\}/s')
-            // ->replaceMatches('/[[:cntrl:]]/mu', '')
-            ->replace(
-                ["\\'", PHP_EOL],
-                ["'", '']
-            );
-    }
 }

app/Generators/GithubCopilotCliGenerator.php

@@ -16,9 +16,6 @@
 
 final class GithubCopilotCliGenerator extends Generator
 {
-    /**
-     * @psalm-suppress UnusedClosureParam
-     */
     public function generate(string $prompt): string
     {
         return resolve(

tests/Unit/Generators/GeneratorTest.php

@@ -18,6 +18,7 @@
  * This source file is subject to the MIT license that is bundled.
  */
 
+use App\Commands\CommitCommand;
 use App\GeneratorManager;
 
 beforeEach(function (): void {
@@ -40,5 +41,9 @@
         OUTPUT;
 
     expect($output)->not->toBeJson()
-        ->and($this->generator->sanitizeJson($output))->toBeJson();
+        ->and(
+            (function (string $message): string {
+                return $this->tryFixMessage($message);
+            })->call(app(CommitCommand::class), $output)
+        )->toBeJson();
 })->group(__DIR__, __FILE__);