Skip to content

Conversation

CalebCourier
Copy link
Collaborator

@CalebCourier CalebCourier commented Sep 16, 2024

Changes

  • Migrate from Credentials class to RC class; make this a config type class that is 1:1 with the .guardrailsrc file
  • Track RC config on user settings; this gives us one place to fetch the config instead of re-reading from the file every time and allows the user to set config values programmatically.
  • Add span attribute to distinguish structured data output from unstructured
  • Use span contexts for time spans
    • Make tracing methods generic so we don't alter the return types
    • The above didn't work because the type checkers don't allow a TypeVar (generic) to represent a different TypeVar if the latter is bound to other types. The solution instead was to just remove typing from the trace methods' signature so they do not override the original methods annotations.

@notion-workspace
Copy link

Telemetry Updates

@CalebCourier CalebCourier marked this pull request as ready for review September 20, 2024 16:20
@CalebCourier CalebCourier requested a review from a team September 20, 2024 16:21
@CalebCourier CalebCourier merged commit b40b514 into main Sep 24, 2024
12 checks passed
@CalebCourier CalebCourier deleted the telemetry-update branch September 24, 2024 17:10
" Please run `guardrails configure` and try again."
)
self.hub_jwt_token = get_jwt_token(self.creds)
self.hub_jwt_token = get_jwt_token(settings.rc)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants