-
Notifications
You must be signed in to change notification settings - Fork 464
Telemetry update #1071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Telemetry update #1071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtam
reviewed
Sep 23, 2024
dtam
reviewed
Sep 23, 2024
dtam
reviewed
Sep 23, 2024
dtam
reviewed
Sep 23, 2024
dtam
reviewed
Sep 23, 2024
dtam
approved these changes
Sep 24, 2024
" Please run `guardrails configure` and try again." | ||
) | ||
self.hub_jwt_token = get_jwt_token(self.creds) | ||
self.hub_jwt_token = get_jwt_token(settings.rc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Credentials
class toRC
class; make this a config type class that is 1:1 with the.guardrailsrc
fileRC
config on user settings; this gives us one place to fetch the config instead of re-reading from the file every time and allows the user to set config values programmatically.Make tracing methods generic so we don't alter the return types