import tele changes #525
Merged
import tele changes #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalebCourier
reviewed
Jan 3, 2024
CalebCourier
reviewed
Jan 3, 2024
CalebCourier
reviewed
Jan 3, 2024
CalebCourier
reviewed
Jan 3, 2024
CalebCourier
reviewed
Jan 3, 2024
CalebCourier
reviewed
Jan 3, 2024
CalebCourier
reviewed
Jan 3, 2024
CalebCourier
reviewed
Jan 3, 2024
There was a problem hiding this comment.
There are a few changes missing. I commented on the files for those. Also we should move over the tests for these changes as well.
Tests:
- https://github.com/guardrails-ai/guardrails-internal/blob/telemetry/tests/integration_tests/test_guard.py#L655
- https://github.com/guardrails-ai/guardrails-internal/blob/telemetry/tests/unit_tests/stores/test_context.py
- https://github.com/guardrails-ai/guardrails-internal/blob/telemetry/tests/unit_tests/utils/test_telemetry_utils.py
* Add OpenTelemetry class for validator hub * Init global tracer, use it to create nested spans to send usage data * Add placeholder cli classes to get creds from local file; will have merge conflicts in future when merging hub-cli * Update class, endpoint, add new methods for context * Add new span, update existing spans, one parent, multiple children * Update endpoint * Lint * Update credentials, and add logger * Add util method that will create spans from anywhere, update existing ways * Replace print with logging * Add opt-out * Update str var to bool * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is (mostly) stolen from a fork by @CalebCourier