Add make target for local typing runs #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShreyaR
force-pushed
the
shreya/add-make-type-local-alias
branch
from
2cb1c9e to
0af52ca
Compare
CalebCourier
previously approved these changes
Mar 7, 2024
There was a problem hiding this comment.
@ShreyaR this is great! I would actually say just make this the default type command. If we want to see how it fails across different versions locally we could either trigger that manually or with a type-xv or something
ShreyaR
force-pushed
the
shreya/add-make-type-local-alias
branch
from
0af52ca to
3696ad9
Compare
|
Merging based on previous approved review by @CalebCourier. Updated the PR with Caleb's comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are different typing targets in the make file based on the versions of
pydanticandopenai.This PR adds a new
maketarget calledtype-localthat runs the appropriate typing target based on the correct versions ofpydanticandopenai.