Skip to content

Conversation

zsimjee
Copy link
Collaborator

@zsimjee zsimjee commented Mar 8, 2024

This makes it possible to use the .use syntax with guard.call()

@zsimjee
Copy link
Collaborator Author

zsimjee commented Mar 11, 2024

Alright making a couple of changes here

  1. Update docstrings to say that call on guards constructed using use and use_many is only supported for string-style guards
  2. Throw an exception when use is called on pydantic-style or object-style guards

@zsimjee zsimjee closed this Mar 11, 2024
@zsimjee zsimjee reopened this Mar 11, 2024
@zsimjee
Copy link
Collaborator Author

zsimjee commented Mar 12, 2024

Ready for review

Copy link
Collaborator

@ShreyaR ShreyaR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zsimjee zsimjee merged commit 13fbe7c into main Mar 12, 2024
@ShreyaR ShreyaR deleted the use-call branch March 29, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants