-
Notifications
You must be signed in to change notification settings - Fork 464
Make on_fail an enum #674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make on_fail an enum #674
Conversation
This reverts commit 55f8d2c.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #674 +/- ##
=======================================
Coverage ? 80.40%
=======================================
Files ? 123
Lines ? 7043
Branches ? 0
=======================================
Hits ? 5663
Misses ? 1380
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Awesome work on this one! Let me know if you need any help with tests. We can roll this out with 0.4.3 next Monday |
Thanks @zsimjee! All tests should be passing. Also @ShreyaR this PR is the fix for issue #582 |
This PR fixes this issue and makes
on_fail
an enum. With this update, the way that we construct a RAIL with pydantic changes:Pydantic:
With XML, constructing a RAIL stays the same and we directly pass in the string "reask". The string is then parsed into an
OnFailAction
enum type.