Make error spans count length by validator, not by guard #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add doc-building instructions
I've encountered an issue with the code example provided for using Guard with CompetitorCheck and ToxicLanguage. The issue is related to the syntax and the use of the use_many method in the Guard class.
Resolved - Error in Guard validation code example in README.md
zsimjee
reviewed
Jun 25, 2024
Comment on lines
+89
to
+91
| validator_name = log.validator_name | ||
| if total_len_by_validator.get(validator_name) is None: | ||
| total_len_by_validator[validator_name] = 0 |
There was a problem hiding this comment.
How does this work for structured data or other scenarios where the same validator may be used multiple times with different params
zsimjee
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.