Skip to content

Add none checks #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: 0.5.x dev
merged 2 commits into from
Jul 2, 2024
Merged

Add none checks #882

merged 2 commits into from
Jul 2, 2024

Conversation

@nichwch
Copy link
Contributor

@nichwch nichwch commented Jul 2, 2024

Using falsy checks instead of None checks against output is vulnerable to cases where output is an empty string.

@CalebCourier CalebCourier changed the base branch from main to 0.5.0-dev July 2, 2024 21:37
JosephCatrambone
JosephCatrambone approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@JosephCatrambone JosephCatrambone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches.

@nichwch nichwch merged commit 961bac8 into 0.5.0-dev Jul 2, 2024
@nichwch nichwch deleted the nichwch/none-check branch July 2, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JosephCatrambone JosephCatrambone JosephCatrambone approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nichwch @JosephCatrambone