Skip to content

[Feat] Allow empty guard create. #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: 0.5.x dev
merged 5 commits into from
Jul 9, 2024
Merged

[Feat] Allow empty guard create. #893

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a13e184
Bugfix: when 'None' is passed explicitly to _set_num_reasks we don't …
JosephCatrambone Jul 8, 2024
910dd11
Swap default=1 to default=None.
JosephCatrambone Jul 8, 2024
99f9ee5
Merge branch '0.5.0-dev' of github.com:guardrails-ai/guardrails into …
JosephCatrambone Jul 9, 2024
332ea52
Make --validators an optional parameter. Create an empty config file…
JosephCatrambone Jul 9, 2024
8327b4f
Fixing lint.
JosephCatrambone Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions guardrails/cli/create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
@gr_cli.command(name="create")
def create_command(
validators: str = typer.Option(
help="A comma-separated list of validator hub URIs. ",
default="",
help="A comma-separated list of validator hub URIs.",
),
name: Optional[str] = typer.Option(
default=None, help="The name of the guard to define in the file."
Expand Down Expand Up @@ -74,7 +75,11 @@ def check_filename(filename: Union[str, os.PathLike]) -> str:

def split_and_install_validators(validators: str, dry_run: bool = False):
"""Given a comma-separated list of validators, check the hub to make sure all of
them exist, install them, and return a list of 'imports'."""
them exist, install them, and return a list of 'imports'. If validators is empty,
returns an empty list."""
if not validators:
return []

stripped_validators = list()
manifests = list()
site_packages = get_site_packages_location()
Expand Down Expand Up @@ -123,7 +128,7 @@ def generate_config_file(validators: List[str], name: Optional[str] = None) -> s
# Import one or more validators.
if len(validators) == 1:
config_lines.append(f"from guardrails.hub import {validators[0]}")
else:
elif len(validators) > 1:
multiline_import = ",\n\t".join(validators)
config_lines.append(f"from guardrails.hub import (\n\t{multiline_import}\n)")

Expand All @@ -135,7 +140,7 @@ def generate_config_file(validators: List[str], name: Optional[str] = None) -> s
# Append validators:
if len(validators) == 1:
config_lines.append(f"guard.use({validators[0]}( TODO Fill these parameters ))")
else:
elif len(validators) > 1:
multi_use = ",\n".join(
[
"\t" + validator + "( TODO fill these parameters )"
Expand Down