Skip to content

Conversation

@shiv07tiwari
Copy link
Contributor

#871

Description

This PR fixes an issue where the jwt library would clash with PyJWT library.

Changes:

  1. Remove jwt and install PyJWT
  2. Call its decode method in get_jwt_token
  3. Accordingly change the unit test method

jayercule and others added 12 commits June 4, 2024 14:18
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [certifi](https://github.com/certifi/python-certifi) from 2024.2.2 to 2024.7.4.
- [Commits](certifi/python-certifi@2024.02.02...2024.07.04)

---
updated-dependencies:
- dependency-name: certifi
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [zipp](https://github.com/jaraco/zipp) from 3.18.2 to 3.19.1.
- [Release notes](https://github.com/jaraco/zipp/releases)
- [Changelog](https://github.com/jaraco/zipp/blob/main/NEWS.rst)
- [Commits](jaraco/zipp@v3.18.2...v3.19.1)

---
updated-dependencies:
- dependency-name: zipp
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…p/zipp-3.19.1

Bump zipp from 3.18.2 to 3.19.1
…p/certifi-2024.7.4

Bump certifi from 2024.2.2 to 2024.7.4
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.2.1 to 2.2.2.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@2.2.1...2.2.2)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…p/urllib3-2.2.2

Bump urllib3 from 2.2.1 to 2.2.2
…m_and_yarn/braces-3.0.3

Bump braces from 3.0.2 to 3.0.3
Integrating recommended changes into telemetry doc
@zsimjee
Copy link
Collaborator

zsimjee commented Jul 11, 2024

@AlejandroEsquivel to drive this to completion by doing the following

  1. test manuallly
  2. fix broken tests (if any)
  3. determine whether to leave this on main or merge into 0.5.0
  4. check in with Windows ppl to see if this resolved any problems
  5. close [feat] Get rid of python-jwt in favour of PyJWT, or make it an optional dependency.  #871

@AlejandroEsquivel AlejandroEsquivel changed the base branch from main to 0.5.0-dev July 11, 2024 18:11
@AlejandroEsquivel
Copy link
Member

Thanks for your contribution @shiv07tiwari 🙏🏼 We are going to try to get this into our upcoming release, as a result I will just have to make some minor changes for it to be compatible with the upcoming version but everything looks great from your end

Copy link
Member

@AlejandroEsquivel AlejandroEsquivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good 👌🏼

@zsimjee zsimjee merged commit 1bb65d6 into guardrails-ai:0.5.0-dev Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] Get rid of python-jwt in favour of PyJWT, or make it an optional dependency.

5 participants