Skip to content

Explicit file encoding to utf-8 for configuration file #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: 0.5.x dev
merged 1 commit into from
Jul 11, 2024
Merged

Explicit file encoding to utf-8 for configuration file #911

merged 1 commit into from
Jul 11, 2024

Conversation

@AlejandroEsquivel
Copy link
Member

@AlejandroEsquivel AlejandroEsquivel commented Jul 11, 2024 •
edited
Loading

Updated:

  • Saving/Writing guardrailsrc with explicit utf-8 encoding (instead of reverting to system default)

Notes: PYTHONUTF8=1 also accomplishes this globally

@AlejandroEsquivel AlejandroEsquivel marked this pull request as ready for review July 11, 2024 19:35
@AlejandroEsquivel AlejandroEsquivel requested a review from a team July 11, 2024 19:35
@zsimjee zsimjee merged commit b443db8 into 0.5.0-dev Jul 11, 2024
@zsimjee zsimjee deleted the fix/utf8-explicit-encoding-config-file branch July 11, 2024 20:38
JosephCatrambone
JosephCatrambone reviewed Jul 11, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zsimjee zsimjee zsimjee approved these changes

+1 more reviewer

@JosephCatrambone JosephCatrambone JosephCatrambone left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlejandroEsquivel @JosephCatrambone @zsimjee