[GR-1025]: CI Cleanup #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove CI from main * re-add qc * lint fixes * use uv in qc workflow * debug uv in qc * more debug * use python from uv * wrap quotes * more debug logs * try using virtual environment * cleanup * more cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We will need to sync from upstream as changes are made. The easiest way to do this is to requires our main branch to not be ahead of upstream. Since we do not want to commit the publish script back to upstream, we will track it as a new commit on a "release" branch that we can merge to from our main.
Summary of changes
project.optional-dependenciessection was changed to uv'sdependency-groupswhich is not pip compliant sopip install .[dev]does not work. Instead we must use uv to install the dev dependency group. Additionally, uv installs do not use the appropriate directories to store bin executables from dependencies (like ruff) when running in root, so we must also introduce a virtual environment to control for this in order for the other scripts in the Makefile to work.Additional Notes
TODO After Merge