fix(core): support reactive GraphQL documents in useQuery
#29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents and UI integration
…ved UI consistency
# Conflicts: # packages/operations/src/codegen/gql.ts # packages/operations/src/codegen/graphql.ts
…ced functionality
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for reactive GraphQL documents in the useQuery composable, allowing the query document itself to be a reactive ref or getter that can change at runtime.
Key changes:
- Modified
useQueryto accept reactive document parameters (ref or getter) - Added automatic query restart when the document changes
- Demonstrated the feature with a dynamic todo query in the demo app
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/composables/useQuery.ts | Updated to support reactive documents with MaybeRefOrGetter type and added watcher to restart query on document changes |
| packages/web/src/App.vue | Added demo section showing reactive GraphQL query usage with editable textarea |
| packages/operations/src/entries/queries.graphql | Added Todos query definition to operations |
| .changeset/polite-crabs-obey.md | Added changeset documenting the new feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
guendev
changed the title
useQuery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27