Skip to content

Conversation

@phated
Copy link
Member

@phated phated commented Apr 25, 2017

@sttk I wanted to see if I could understand the process of adding a config property so I attempted to add the --continue flag. Can you review?

@sttk sttk merged commit b11c88e into master Apr 26, 2017
@sttk
Copy link
Contributor

sttk commented Apr 26, 2017

@phated I've reviewed your code, and your work is excellent!

About the process of adding a config property, I think it's not necessary to add a test of test/lib/config-cli-flags.js but it is also good, of course.

I've merged this PR.

@phated phated deleted the config-continue branch April 26, 2017 17:32
@phated
Copy link
Member Author

phated commented Apr 26, 2017

Thanks @sttk! Glad you noticed that I added you to the gulp-cli team. Welcome!

phated pushed a commit that referenced this pull request Dec 21, 2017
Update: Add flags.continue to config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants