Skip to content

Reduce full tree #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Reduce full tree #36

wants to merge 7 commits into from

Conversation

@sandipchitale
Copy link

@sandipchitale sandipchitale commented Sep 20, 2015

Pull request for implementation of:

#35

@phated
Copy link
Member

phated commented Sep 21, 2015

It seems that the test for this has confused you. The treeTree method just outputs a given task tree, it doesn't need to build the dependency tree. The dependency tree is built and stored inside undertaker and does this recursive building already. I will adjust this test so it is less confusing.

@phated phated closed this Sep 21, 2015
@phated phated mentioned this pull request Sep 21, 2015
Closed
@phated
Copy link
Member

phated commented Sep 21, 2015

The test has been updated in 1c0da0d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sandipchitale @phated