Skip to content

Commit 64cc428

Browse files
committed
Fix: Properly handle undefined user & add test
1 parent 2d6b199 commit 64cc428

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const path = require('path');
88
const crypto = require('crypto');
99
const execFile = require('child_process').execFile;
1010
const env = process.env;
11-
const user = env.LOGNAME || env.USER || env.LNAME || env.USERNAME;
11+
const user = env.LOGNAME || env.USER || env.LNAME || env.USERNAME || '';
1212
const exclusions = ['--help'];
1313

1414
const configfile = '.v8flags.'+process.versions.v8+'.'+crypto.createHash('md5').update(user).digest('hex')+'.json';

test.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,17 @@ describe('v8flags', function () {
119119
delete require.cache[require.resolve('./')];
120120
var v8flags = require('./');
121121
console.log(v8flags.configfile);
122+
v8flags(function (err, flags) {
123+
expect(err).to.be.null;
124+
done();
125+
});
126+
});
127+
128+
it('should handle undefined usernames', function(done) {
129+
eraseHome();
130+
delete require.cache[require.resolve('./')];
131+
var v8flags = require('./');
132+
console.log(v8flags.configfile);
122133
v8flags(function (err, flags) {
123134
expect(err).to.be.null;
124135
done();

0 commit comments

Comments
 (0)