Accept predicate function or array of types as type parameter #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.js
Outdated
| return typeof value === type; | ||
| } | ||
| if (typeof type === 'function') { | ||
| return Boolean(type(value)); |
Member
There was a problem hiding this comment.
prefer !!type(value) to covert to boolean
Member
|
A few comments |
Member
|
I found a missed case that wasn't handled. Adding tests and fix now that I'll land in the merge. What do you think about adding a |
Member
|
Ref c458507 |
phated
pushed a commit
that referenced
this pull request
Jun 7, 2016
…#1) * make npm run cover compatible with Windows * accept function or array as type * improve documentation * replace Boolean by double-bang for coercion
Member
|
Published as 1.1.0 - Awesome work! |
Contributor
Author
|
@phated |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this discussion in gulpjs/vinyl-fs#168.
Ping @phated.
Modification in
package.jsonis explained here: gotwarlost/istanbul#90.