Add support for when cluster endpoint is not available #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify `get_cluster_info` to include a timeout (defaults to 3 seconds) and gracefully degrade when the ElastiCache cluster configuration endpoint isn't available by returning the provided `host` and `port` in the `nodes` list. I also added an additional test to the protocol test suite to cover the additional functionality.
Make use of Telnet.expect() to match against the success (END) and failure case (ERROR) in the same call. Update protocol tests to handle patching expect() with output that was previously returned by read_until().
Conditionally ignore failures to `config get cluster` calls against the configured LOCATION endpoint with the introduction of a `IGNORE_CLUSTER_ERRORS` option (that defaults to `False`).
gusdan
requested changes
Feb 4, 2017
django_elasticache/cluster_utils.py
Outdated
|
|
||
|
|
||
| def get_cluster_info(host, port): | ||
| def get_cluster_info(host, port, timeout=3): |
Owner
There was a problem hiding this comment.
let's remove timeouts or use default timeout from cache configuration setting
django_elasticache/memcached.py
Outdated
| 'tcp_nodelay': True, | ||
| 'ketama': True | ||
| 'ketama': True, | ||
| 'IGNORE_CLUSTER_ERRORS': False, |
Owner
There was a problem hiding this comment.
i don't think we should pass IGNORE_CLUSTER_ERRORS to parent class (pylibmc)
django_elasticache/cluster_utils.py
Outdated
|
|
||
|
|
||
| def get_cluster_info(host, port): | ||
| def get_cluster_info(host, port, ignore_cluster_errors=False, timeout=3): |
Contributor
Author
|
I believe that all of your comments have been addressed. |
Contributor
Author
|
Thanks, @gusdan! |
matteiuspi
pushed a commit
to CashStar/django-elasticache
that referenced
this pull request
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify
get_cluster_infoto include a timeout (defaults to 3 seconds) and match against the success (END) and failure case (ERROR) in the same call. From there, gracefully degrade (only if theIGNORE_CLUSTER_ERRORSoption isTrue) when the ElastiCache cluster configuration endpoint isn't available by returning the providedhostandportin thenodeslist.Also, add two additional tests to the protocol test suite to cover the additional functionality.
Fixes #16
Testing
These tests were executed within a Python 2.7 Docker container with all of the necessary dependencies. Let me know if you'd like that setup in a separate PR.