Patched to work with Django 1.7 #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I added support for Django 1.7 and added you test. But i'm afraid to use cached_property instead of thread local in django less than 1.7. Thread safe it's dangerous territory and it can be broken in some situations. So my changes use thread local for django < 1.7 and self for 1.7. |
Author
|
That's great. Thank you! |
matteiuspi
pushed a commit
to CashStar/django-elasticache
that referenced
this pull request
Mar 19, 2021
Add task to deploy pypi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know there is a pull request for this already, but I have a more concise fix that is also backwards compatible.
I have also patched the tests to work with Django 1.6/1.7 and included a test for my fix. This tests that my fix accomplishes the apparent intended behavior of your original version.