Skip to content

Conversation

@seamusmac
Copy link

No description provided.

@seamusmac
Copy link
Author

seamusmac commented Mar 16, 2018

I fixed the issue with this PR. I am going to test on one of our larger projects now.
If thats ok, I think this is good to merge in :) I will let you know.

@seamusmac
Copy link
Author

I tested this on a project with 1k + ui.xml files and it works fine. I intentionally broke some of the ui.xml references and it showed the errors properly. Also then fixed them and it validated all correctly again, so it looks good from my side. Let me know if you need anything else.

@branflake2267 branflake2267 merged commit c92246e into gwt-plugins:master Mar 19, 2018
@branflake2267
Copy link
Contributor

Nice job!

@branflake2267
Copy link
Contributor

I'll schedule to do a staging build tomorrow.

@seamusmac
Copy link
Author

I am not sure, I'm not very experienced in the JDT api, but I moved that down to JLS3 which is java 5, just to be on the safe side. Retested everything and looks good.

@branflake2267
Copy link
Contributor

Sounds good. No worries. I see the others are JLS3, do you think you could create a pull for that?

@seamusmac
Copy link
Author

I already did. See #375 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants