Add support for more WOFF/WOFF2 flavors (Alternative to #117) #118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, according to the WOFF File Format 1.0 and WOFF File Format 2.0 specifications,
In the current state, this library only checks for the TrueType flavor (
0x00010000), but OpenType flavor (0x4F54544F) fonts are common as well, and those are not correctly identified by this library.As an alternative to #117, if you're not comfortable with allowing arbitrary flavors, I'm proposing implementing support for the three flavors mentioned in the specification itself:
0x00010000(already present),0x4F54544Fand0x74727565.