New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ech] rewrite ESNI to ECH draft 15 #437
Conversation
kazuho
commented
Nov 17, 2022
•
edited
edited
- implementation:
- full handshake
- resumption
- HRR
- retry_config
- ech_required alert
- test:
- confirm interop (done with crypto.cloudflare.com)
- add basic tests
- add matrix of tests (incl. rejection, HRR)
@kazuho do you want me to take a look at the failures on the windows test, such as https://ci.appveyor.com/project/kazuho/picotls/builds/45518912/job/ujvonq5v0g948lh5? |
@huitema Thanks I would appreciate that! With this PR, picotls-esni is no longer built (src/esni.c is removed), with the assumption being that we do not need to provide people tools for building ECHConfigList or SVCB / HTTPS resource records. I think that the removal has to be done on MSVC side. |
…es, as the latter could be confusing
…different between ECHConfigs
Let's merge this. It works, we have tests. The API might be unstable. But the fact is that it cannot become stable until RFC is published. |