Skip to content

JI-6488 handle av file upload error #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 24, 2024
Merged

JI-6488 handle av file upload error #275

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8acf230
JI-6488 handle av file upload error
devland Sep 20, 2024
cd71777
JI-6488 fix error selection
devland Sep 24, 2024
b2de444
JI-6488 select boxEl from many
devland Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions scripts/h5peditor-av.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ H5PEditor.widgets.video = H5PEditor.widgets.audio = H5PEditor.AV = (function ($)
self.replaceCallback();
});


self.on('upload', function () {
// Insert throbber
self.$uploading = $('<div class="h5peditor-uploading h5p-throbber">' + H5PEditor.t('core', 'uploading') + '</div>').insertAfter(self.$add.hide());
Expand All @@ -67,7 +66,8 @@ H5PEditor.widgets.video = H5PEditor.widgets.audio = H5PEditor.AV = (function ($)
const updateId = event.data?.updateId ?? undefined;
this.updateId = updateId;
const boxesEl = Array.from(self.$dndFiles.get(0).querySelectorAll('.h5p-dnd__videobox-wrapper:not(.h5p-dnd__videobox-wrapper--is-provider)'));
let boxEl;
const boxEls = self.$dndFiles.get(0).querySelectorAll('.h5p-dnd__box');
let boxEl = boxEls[boxEls.length - 1];

try {
if (result.error) {
Expand Down Expand Up @@ -124,7 +124,7 @@ H5PEditor.widgets.video = H5PEditor.widgets.audio = H5PEditor.AV = (function ($)
errorEls.forEach(errorEl => errorEl.classList.remove('has-error'));
}
catch (error) {
self.setErrorMessage(result.error, boxEl);
self.setErrorMessage(error.message || error, boxEl);
}

if (self.$uploading !== undefined && self.$uploading.length !== 0) {
Expand Down Expand Up @@ -1022,6 +1022,12 @@ H5PEditor.widgets.video = H5PEditor.widgets.audio = H5PEditor.AV = (function ($)
<div class="h5p-loader__icon"></div>
</div>
</div>
<div class="h5p-dnd__row">
<div id="errorContainer" class="video-url-error-container hidden">
<div class="h5p-errors"></div>
</div>
</div>
<div class="h5p-sr-only" aria-live="polite"></div>
</div>
</div>
`;
Expand Down Expand Up @@ -1049,6 +1055,7 @@ H5PEditor.widgets.video = H5PEditor.widgets.audio = H5PEditor.AV = (function ($)
</div>
</div>
`: ''}
<div class="h5p-sr-only" aria-live="polite"></div>
</div>
</div>
`;
Expand Down