Skip to content

Conversation

@YiFeiZhang2
Copy link
Member

@YiFeiZhang2 YiFeiZhang2 commented Jan 18, 2019

Description

Create a /self route for sponsors to get sponsor information from logged in user. This will be used for sponsor creation on the front end, and as part of a new HOC.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Created new tests:

  • fail due to authentication
  • fail due to authorization
  • fail due to wrong account type
  • fail due to sponsor not created yet
  • succeed to get sponsor information from logged in user

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@pierreTklein pierreTklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a mistake with the previous review

@pierreTklein pierreTklein merged commit 13acb25 into develop Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants