Feature/152 accept hacker route

[ManethKulatunge]

Tickets:

• HCK-152

List of changes:

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

• Added a /accept/:id route that can accept a hacker by ID

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)
• This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Failure on someone who is not authenticated
  Failure on someone who is not authorized
  Failure on invalid input
  Success for accepting a hacker.
  On hacker.test.js

• POSTMAN Patch request to hacker/accept/:id

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Questions for code reviewers?

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have made corresponding changes to the documentation
• Any dependent changes have been merged and published in downstream modules

[printharsh]

Since this is a middleware, just put it under the route, remove this line and call next()

[pierreTklein]

To add onto Harsh's comment:

function parseAccept(req, res, next) {
    req.body.status = Constants.General.HACKER_STATUS_ACCEPTED;
    next();
}

and then in routes/hacker.js:

...
Middleware.Hacker.parseAccept,
Middleware.Hacker.updateHacker,
...

[printharsh]

Nit: Rename function to parseAccept, similar to parseConfirmation and make comment just say it sets the req.body.status to accepted

[printharsh]

Looks good! Just very minor nits, could you also add some tests (under hacker.test.js PATCH update one hacker tests should be very similar to the ones you'd write).

[pierreTklein]

LGTM, added to Harsh's comment.

[pierreTklein]

To add onto Harsh's comment:

function parseAccept(req, res, next) {
    req.body.status = Constants.General.HACKER_STATUS_ACCEPTED;
    next();
}

and then in routes/hacker.js:

...
Middleware.Hacker.parseAccept,
Middleware.Hacker.updateHacker,
...

[pierreTklein]

This function should not be async.

[pierreTklein]

Please include some additional tests for this route:

• Failure on someone who is not authenticated
• Failure on someone who is not authorized
• Failure on invalid input
• Success for accepting a hacker.

[loreina]

can we revert changes that happened in docs folder aside from your changes

[loreina]

one versioning change, everything else looks great !!!