Skip to content

Feature/128 add application pagescreens #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 13, 2019
Merged

Feature/128 add application pagescreens #614

merged 2 commits into from
Dec 13, 2019

Conversation

@RohitGarudadri
Copy link
Contributor

@RohitGarudadri RohitGarudadri commented Dec 13, 2019 •
edited
Loading

Tickets:

List of changes:

Quick fix to change updatehacker validation

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Passed all tests

Questions for code reviewers?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

loreina
loreina approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@loreina loreina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after a thorough and highly calculated review, I think this lgtm 🎉

printharsh
printharsh approved these changes Dec 13, 2019
View reviewed changes
Copy link

@printharsh printharsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Do we need tests for those with travel reimbursement?

@RohitGarudadri RohitGarudadri merged commit bf20773 into develop Dec 13, 2019
@RohitGarudadri RohitGarudadri deleted the feature/128-add-application-pagescreens branch December 13, 2019 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@printharsh printharsh printharsh approved these changes

@loreina loreina loreina approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RohitGarudadri @printharsh @loreina