Skip to content

Conversation

@pierreTklein
Copy link
Member

@pierreTklein pierreTklein commented Dec 17, 2019

Tickets:

HCK-185
image

List of changes:

Added check to updateAccount middleware to see whether or not the new email already exists in the database, and if so, return a dup email error.

Error should now be: "Email already in use"
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Ran test suite

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@loreina loreina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

@loreina loreina merged commit 77d4837 into develop Dec 17, 2019
@loreina loreina deleted the bugfix/dup-email branch December 17, 2019 05:11
@loreina
Copy link
Member

loreina commented Dec 17, 2019

closes #619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants