Removed needsBus and added/fixed tests for travel #625
Conversation
| }) | ||
| .withMessage( | ||
| `${fieldname} must be between ${lowerBound} and ${upperBound}` | ||
| `${fieldname} must be between ${lowerBound} and ${upperBound}` |
There was a problem hiding this comment.
does this only validate that travel is an integer? or does it also cover the [0,100] inclusive bound?
There was a problem hiding this comment.
I made a new test all together that also validates the 0-100 bound
There was a problem hiding this comment.
does it validate float vs int? or is that being done on front end?
There was a problem hiding this comment.
@Ty-Won that would be a frontend validation, I'll have a PR for that tn 😉
There was a problem hiding this comment.
If we want to stay properly RESTful the int validation should be on the API
There was a problem hiding this comment.
Agreed we should have api validation
There was a problem hiding this comment.
The validator does check .isInt() which seems to work. If I input a float, like 10.5 for travel, then indeed the error appears saying that it should be an integer. Do we need more than this?
There was a problem hiding this comment.
Seems good to me, I also added int validation on the frontend: hackmcgill/dashboard#764
| }; | ||
|
|
||
| // duplicate of newHack0, but with 101 for travel | ||
| const invalidHacker2 = { |
There was a problem hiding this comment.
are we missing tests for impairments and barriers? I'll make a ticket if we are
There was a problem hiding this comment.
Yes, there are no tests for those currently.
Tickets:
HCK-194, 176
List of changes:
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Questions for code reviewers?
Checklist: