Skip to content

Conversation

@loreina
Copy link
Member

@loreina loreina commented Dec 29, 2019

Tickets:

List of changes:

  • Add 3 days left marketing email to /marketingEmail
  • Fix unsubscribe button in marketing emails

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

Questions for code reviewers?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Listed change(s) in the Changelog
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@isabelledelmundo isabelledelmundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@loreina loreina merged commit 34e391e into develop Jan 1, 2020
@loreina loreina deleted the feature/add-email-blast branch January 1, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants