Skip to content

Conversation

@RohitGarudadri
Copy link
Contributor

…ssed

Tickets:

List of changes:

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Added a check to prevent that applications are not created after the closing time

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Screenshot provided for error message upon submitting past the date
  • Test B

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Questions for code reviewers?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Listed change(s) in the Changelog
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
    Screen Shot 2020-01-01 at 4 39 07 PM

@RohitGarudadri RohitGarudadri requested a review from loreina January 1, 2020 21:44
hacker = new Hacker(hackerDetails);
return hacker.save();
}
throw new Error("Application creation deadline has passed!");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the application deadline has passed!

@RohitGarudadri RohitGarudadri requested a review from loreina January 1, 2020 21:49
Copy link
Member

@loreina loreina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good. how can we test that it works though?

@RohitGarudadri
Copy link
Contributor Author

I was trying to figure out a way to mock the date to create a test for this, but wasn't able to mock the date without having other things get messed up, so not sure :/

@RohitGarudadri RohitGarudadri merged commit 84f3587 into develop Jan 1, 2020
@RohitGarudadri RohitGarudadri deleted the feature/73-application-date branch January 1, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants