Skip to content

Validation removed for Application Close Time #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2020
Merged

Validation removed for Application Close Time #636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbdae7b
Validation removed for Application Close Time
ManethKulatunge Jan 10, 2020
4c5c372
update changelog
loreina Jan 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

### Changed

- Comment out application close validation

## [2.1.2](https://github.com/hackmcgill/hackerapi/tree/2.1.2) - 2020-01-05

### Changed
Expand Down
10 changes: 5 additions & 5 deletions services/hacker.service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ function createHacker(hackerDetails) {

let hacker;

if (Date.now() < Constants.APPLICATION_CLOSE_TIME) {
hacker = new Hacker(hackerDetails);
return hacker.save();
}
throw new Error("Sorry, the application deadline has passed!");
//if (Date.now() < Constants.APPLICATION_CLOSE_TIME) {
hacker = new Hacker(hackerDetails);
return hacker.save();
//}
//throw new Error("Sorry, the application deadline has passed!");
}

/**
Expand Down