Skip to content

Removed travel permissions from hacker #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 15, 2020
Merged

Removed travel permissions from hacker #643

merged 2 commits into from
Jan 15, 2020

Conversation

@printharsh
Copy link

@printharsh printharsh commented Jan 15, 2020

List of changes:

Removed travel routes that could access any hacker from constants file.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Questions for code reviewers?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Listed change(s) in the Changelog
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@printharsh printharsh requested review from logan-r and loreina January 15, 2020 21:19
@loreina loreina merged commit 0a2ebe1 into develop Jan 15, 2020
@loreina loreina deleted the bugfix/travelRoutes branch January 15, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loreina loreina loreina approved these changes

@logan-r logan-r Awaiting requested review from logan-r

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@printharsh @loreina