Skip to content

Conversation

@Ty-Won
Copy link
Member

@Ty-Won Ty-Won commented Jan 31, 2020

Tickets:

  • HCK-

List of changes:

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Added the live site link to the template for status check in

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New release
  • This change requires a documentation update

How has this been tested?

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Questions for code reviewers?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Listed change(s) in the Changelog
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@Ty-Won Ty-Won requested a review from loreina January 31, 2020 20:25
@loreina
Copy link
Member

loreina commented Jan 31, 2020

send pic of what this looks like please

@Ty-Won
Copy link
Member Author

Ty-Won commented Jan 31, 2020

image

@loreina

Copy link
Member

@loreina loreina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 🔥

please update changelog and merge

@Ty-Won Ty-Won merged commit e182b02 into develop Jan 31, 2020
@Ty-Won Ty-Won deleted the email-checkin-update branch January 31, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants